Skip to content

fix Exception stack information acquisition optimization #6984 #6985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Dec 4, 2020

fix Exception stack information acquisition optimization #6984

@codecov-io
Copy link

Codecov Report

Merging #6985 (9c44077) into master (3fc2d10) will decrease coverage by 0.59%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6985      +/-   ##
============================================
- Coverage     59.44%   58.84%   -0.60%     
+ Complexity      511      504       -7     
============================================
  Files          1028     1028              
  Lines         41519    41475      -44     
  Branches       6037     6006      -31     
============================================
- Hits          24681    24408     -273     
- Misses        14102    14307     +205     
- Partials       2736     2760      +24     
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java 80.55% <80.00%> (-0.09%) 0.00 <0.00> (ø)
...rc/main/java/org/apache/dubbo/rpc/AppResponse.java 51.38% <100.00%> (-3.16%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 36.00% <0.00%> (-45.34%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 47.88% <0.00%> (-42.26%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-34.49%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/dubbo/DubboRegistry.java 43.13% <0.00%> (-13.73%) 9.00% <0.00%> (-1.00%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...9c44077. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 3c9cd79 into apache:master Feb 23, 2021
@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Feb 23, 2021
@CrazyHZM CrazyHZM deleted the stackTraceOptimization branch April 27, 2021 05:54
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants