-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-#7089] NacosRegistry register instance support PreservedMetadataKeys #7090
Conversation
@AlbumenJ PTAL |
…aram to control the instance.
Codecov Report
@@ Coverage Diff @@
## master #7090 +/- ##
============================================
- Coverage 59.06% 58.83% -0.23%
+ Complexity 462 461 -1
============================================
Files 1043 1044 +1
Lines 42445 42473 +28
Branches 6222 6227 +5
============================================
- Hits 25071 24991 -80
- Misses 14574 14660 +86
- Partials 2800 2822 +22 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If the PR is merged, please update the corresponding document in https://github.com/apache/dubbo-website
That's fine, also append a pr to use it in dubbo-sample. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
For-#7089