Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-7054]消费者端Executor调整为“全局共享”、“按提供者隔离”2个可选模式 #7120

Closed
wants to merge 10 commits into from

Conversation

zhangyz-hd
Copy link
Contributor

@zhangyz-hd zhangyz-hd commented Jan 21, 2021

What is the purpose of the change

这是在 #7109 基础上进一步将消费者端Executor调整为“全局共享”、“按提供者隔离”2个可选模式,默认工作在全局共享,可以通过dubbo:consumer的share.threadpool进行设置。

<dubbo:consumer>
    <dubbo:parameter key="share.threadpool" value="false"/>
</dubbo:consumer>

备注:share.threadpool参数命名沿用自2.6.9

Brief changelog

  1. 如果share.threadpool=true,DefaultExecutorRepository在createExecutor时返回包装后的ShareableExecutor。
  2. AbstractClient在close时,如果executor为ShareableExecutor这不处理executor.shutdown。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #7120 (691e02c) into master (bd43fa7) will decrease coverage by 0.33%.
The diff coverage is 75.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7120      +/-   ##
============================================
- Coverage     60.07%   59.74%   -0.34%     
+ Complexity      506      288     -218     
============================================
  Files          1028     1002      -26     
  Lines         41531    39982    -1549     
  Branches       6038     5934     -104     
============================================
- Hits          24951    23886    -1065     
+ Misses        13813    13370     -443     
+ Partials       2767     2726      -41     
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...pache/dubbo/remoting/transport/AbstractClient.java 61.74% <16.66%> (-1.27%) 0.00 <0.00> (ø)
.../threadpool/manager/DefaultExecutorRepository.java 83.58% <83.33%> (-4.56%) 0.00 <0.00> (ø)
...che/dubbo/common/threadpool/ShareableExecutor.java 81.81% <85.71%> (ø) 0.00 <0.00> (?)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 41.97% <100.00%> (-0.06%) 0.00 <0.00> (ø)
...che/dubbo/common/utils/CharSequenceComparator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...che/dubbo/rpc/cluster/support/FailfastCluster.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/interceptor/ClusterInterceptor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...java/org/apache/dubbo/remoting/etcd/Constants.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...pache/dubbo/metadata/report/support/Constants.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd43fa7...cf3d3b7. Read the comment docs.

reFix ExecutorRepositoryTest
@chickenlj
Copy link
Contributor

duplicat of #7109

@chickenlj chickenlj closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants