Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter chain order #7305

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

chickenlj
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #7305 (bb53679) into master (51d5a88) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7305      +/-   ##
============================================
+ Coverage     58.92%   59.01%   +0.08%     
+ Complexity      462      461       -1     
============================================
  Files          1044     1044              
  Lines         42455    42472      +17     
  Branches       6222     6228       +6     
============================================
+ Hits          25017    25063      +46     
+ Misses        14619    14602      -17     
+ Partials       2819     2807      -12     
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 81.81% <100.00%> (ø) 0.00 <0.00> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/rpc/protocol/AbstractExporter.java 60.00% <0.00%> (-1.12%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 58.75% <0.00%> (-0.51%) 0.00% <0.00%> (ø%)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.81% <0.00%> (-0.40%) 27.00% <0.00%> (-1.00%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 42.02% <0.00%> (-0.10%) 0.00% <0.00%> (ø%)
.../rpc/cluster/router/condition/ConditionRouter.java 68.75% <0.00%> (ø) 0.00% <0.00%> (ø%)
...apache/dubbo/rpc/protocol/dubbo/DubboExporter.java 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d5a88...bb53679. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit d40a1fd into apache:master Mar 3, 2021
@chickenlj chickenlj deleted the fix-filter-chain-order branch March 30, 2021 08:59
@yifanzzz
Copy link

yifanzzz commented May 9, 2023

I don't know that why to change the filter order? @AlbumenJ

@AlbumenJ
Copy link
Member

I don't know that why to change the filter order? @AlbumenJ

For dubbo filter chain, smaller is higher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants