Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7339] Didn't judge check in serviceDiscoveryRegistry #7340

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7339.
Didn't judge check in serviceDiscoveryRegistry, it should take over by ReferenceConfig.checkInvokerAvailable

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #7340 (2d55adf) into master (2062cdb) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7340      +/-   ##
============================================
- Coverage     59.06%   58.61%   -0.45%     
+ Complexity      463      425      -38     
============================================
  Files          1044     1044              
  Lines         42485    42487       +2     
  Branches       6230     6230              
============================================
- Hits          25094    24905     -189     
- Misses        14591    14783     +192     
+ Partials       2800     2799       -1     
Impacted Files Coverage Δ Complexity Δ
...ubbo/registry/client/ServiceDiscoveryRegistry.java 50.59% <100.00%> (+0.59%) 0.00 <0.00> (ø)
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.59%) 0.00% <0.00%> (-31.00%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2062cdb...2d55adf. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit fab59fc into apache:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants