Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve use api, application-level service discovery model startup error #7352

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Use api, application-level service discovery model startup error

see more detail from #7351

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #7352 (fb179de) into master (96e44f6) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7352      +/-   ##
============================================
- Coverage     59.08%   58.68%   -0.41%     
+ Complexity      461      428      -33     
============================================
  Files          1044     1044              
  Lines         42489    42486       -3     
  Branches       6231     6230       -1     
============================================
- Hits          25104    24932     -172     
- Misses        14584    14758     +174     
+ Partials       2801     2796       -5     
Impacted Files Coverage Δ Complexity Δ
...mon/src/main/java/org/apache/dubbo/common/URL.java 50.05% <ø> (+1.14%) 0.00 <0.00> (ø)
...ry/client/metadata/MetadataServiceNameMapping.java 3.44% <ø> (+0.22%) 0.00 <0.00> (ø)
...istry/client/DefaultRegistryClusterIdentifier.java 66.66% <100.00%> (ø) 0.00 <0.00> (ø)
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.00%) 0.00% <0.00%> (-31.00%)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e44f6...6f568af. Read the comment docs.

@AlbumenJ
Copy link
Member

Fix #7351

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit e943af0 into apache:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants