Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java box to prevent malicious code. #7428

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

If users want prevent maliciout code in router script.
step one: define a custom security file with content

grant {
	  permission java.security.AllPermission;
};

step two: start dubbo-consumer with system property: -Djava.security.manager -Djava.security.policy=customFile location.

This solution maybe decrese the application performance.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj added this to the 2.7.10 milestone Mar 23, 2021
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 9b7575a into apache:master Mar 26, 2021
@horizonzy
Copy link
Member Author

The scriptRouter be removed at this pr, if user still wants use it, add scriptRouterFactory in selfs spi file.

vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants