Optimize the selection of invokers in the multi-registry scenario #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7446 +/- ##
============================================
+ Coverage 59.12% 59.29% +0.17%
- Complexity 456 503 +47
============================================
Files 1043 1076 +33
Lines 42516 43180 +664
Branches 6226 6293 +67
============================================
+ Hits 25136 25603 +467
- Misses 14593 14748 +155
- Partials 2787 2829 +42
Continue to review full report at Codecov.
|
horizonzy
reviewed
Mar 28, 2021
| @@ -369,19 +373,43 @@ private T createProxy(Map<String, String> map) { | |||
| List<Invoker<?>> invokers = new ArrayList<Invoker<?>>(); | |||
| URL registryURL = null; | |||
| for (URL url : urls) { | |||
| invokers.add(REF_PROTOCOL.refer(interfaceClass, url)); | |||
| Invoker<?> referInvoker = REF_PROTOCOL.refer(interfaceClass, url); | |||
There was a problem hiding this comment.
If the provider didn't start first. Wait consumer start for a while, when provider start, the provider still be subscribe?
There was a problem hiding this comment.
If check=true, an error will be reported, otherwise it will be subscribed
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Optimize the selection of invokers in the multi-registry scenario.
In the multi-registry scenario, if a service is not under a certain registry, the invoker can be filtered out in advance.
see more detail from #7444
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.