Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aubbo_configcenter_apollo_removeListener_test #7893

Merged
merged 1 commit into from
May 28, 2021

Conversation

luox2
Copy link

@luox2 luox2 commented May 27, 2021

What is the purpose of the change

Add unit test for ApolloDynamicConfiguration #7892

Brief changelog

Update org/apache/dubbo/configcenter/support/apollo/ApolloDynamicConfiguration.java file

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #7893 (6637a0a) into master (49e6701) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7893      +/-   ##
============================================
- Coverage     59.61%   59.61%   -0.01%     
  Complexity      556      556              
============================================
  Files          1088     1088              
  Lines         43847    43855       +8     
  Branches       6400     6404       +4     
============================================
+ Hits          26141    26145       +4     
+ Misses        14804    14793      -11     
- Partials       2902     2917      +15     
Impacted Files Coverage Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-13.80%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-11.12%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 90.69% <0.00%> (-2.33%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.14% <0.00%> (-1.49%) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100.00% <0.00%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...he/dubbo/registry/multicast/MulticastRegistry.java 68.37% <0.00%> (+0.93%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e6701...6637a0a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 515699b into apache:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants