cherry pick pr7109 to 3.0 #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #7950 +/- ##
============================================
- Coverage 59.81% 59.54% -0.27%
Complexity 326 326
============================================
Files 1086 1086
Lines 44360 44360
Branches 6626 6625 -1
============================================
- Hits 26534 26416 -118
- Misses 14906 15024 +118
Partials 2920 2920
Continue to review full report at Codecov.
|
AlbumenJ
reviewed
Jun 3, 2021
| Map<Integer, ExecutorService> executors = data.computeIfAbsent(componentKey, k -> new ConcurrentHashMap<>()); | ||
| Integer portKey = url.getPort(); | ||
| Map<Integer, ExecutorService> executors = data.computeIfAbsent(EXECUTOR_SERVICE_COMPONENT_KEY, k -> new ConcurrentHashMap<>()); | ||
| //issue-7054:Consumer's executor is sharing globally, key=Integer.MAX_VALUE. Provider's executor is sharing by protocol. |
There was a problem hiding this comment.
please remove issue count and refer it in pr comment
AlbumenJ
reviewed
Jun 3, 2021
| @@ -127,16 +122,20 @@ public ExecutorService getExecutor(URL url) { | |||
| return null; | |||
| } | |||
|
|
|||
| Integer portKey = url.getPort(); | |||
| //issue-7054:Consumer's executor is sharing globally, key=Integer.MAX_VALUE. Provider's executor is sharing by protocol. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Cherry pick commits from #7109 to 3.0 branch, to fix #7054.
Checklist