Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue-8516 on 2.6.x: fix mock:true configuration #8623

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

changfubai
Copy link
Contributor

fix #8516 on branch 2.6.x.
ps: this commit has been merge into 3.0 and master branch.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #8623 (35fed07) into 2.6.x (f62ca3f) will increase coverage by 0.34%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #8623      +/-   ##
============================================
+ Coverage     47.04%   47.39%   +0.34%     
- Complexity     4472     4519      +47     
============================================
  Files           577      577              
  Lines         25631    25632       +1     
  Branches       4546     4547       +1     
============================================
+ Hits          12059    12148      +89     
+ Misses        11710    11602     -108     
- Partials       1862     1882      +20     
Impacted Files Coverage Δ
...ava/com/alibaba/dubbo/rpc/support/MockInvoker.java 57.40% <66.66%> (+57.40%) ⬆️
...aba/dubbo/remoting/transport/mina/MinaChannel.java 42.25% <0.00%> (-11.27%) ⬇️
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0.00%> (-1.87%) ⬇️
...baba/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0.00%> (+1.53%) ⬆️
.../alibaba/dubbo/rpc/proxy/AbstractProxyFactory.java 4.76% <0.00%> (+4.76%) ⬆️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 88.88% <0.00%> (+5.55%) ⬆️
...n/java/com/alibaba/dubbo/rpc/support/RpcUtils.java 27.02% <0.00%> (+6.75%) ⬆️
...src/main/java/com/alibaba/dubbo/rpc/RpcResult.java 46.15% <0.00%> (+7.69%) ⬆️
...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java 25.55% <0.00%> (+10.00%) ⬆️
...bbo/rpc/proxy/wrapper/StubProxyFactoryWrapper.java 18.42% <0.00%> (+18.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62ca3f...35fed07. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 59da412 into apache:2.6.x Sep 3, 2021
@changfubai changfubai deleted the issue-8516-2.6 branch September 9, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants