Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] set client to null at LazyConnectExchangeClient close methods #8881

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 23, 2021

What is the purpose of the change

#8880

  • set the client field of LazyConnectExchangeClient to null at the end of close() and close(int timeout) methods
  • move close status setting from HeaderExchangeChannel close(timeout) to close()

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #8881 (c034b72) into 3.0 (eb574aa) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8881      +/-   ##
============================================
+ Coverage     63.38%   63.40%   +0.01%     
- Complexity      314      315       +1     
============================================
  Files          1178     1178              
  Lines         49810    49815       +5     
  Branches       7452     7452              
============================================
+ Hits          31571    31583      +12     
+ Misses        14796    14787       -9     
- Partials       3443     3445       +2     
Impacted Files Coverage Δ
...exchange/support/header/HeaderExchangeChannel.java 78.84% <33.33%> (-1.55%) ⬇️
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 55.91% <100.00%> (-2.33%) ⬇️
...c/protocol/dubbo/ReferenceCountExchangeClient.java 65.00% <100.00%> (ø)
...pache/dubbo/remoting/transport/AbstractClient.java 61.42% <0.00%> (-4.29%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-2.18%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 46.25% <0.00%> (-0.89%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 66.04% <0.00%> (+0.21%) ⬆️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (+0.32%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.18% <0.00%> (+0.90%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb574aa...c034b72. Read the comment docs.

@zrlw zrlw changed the title reset the client value of LazyConnectExchangeClient after close [3.0] reset the client value of LazyConnectExchangeClient after close Sep 23, 2021
@zrlw zrlw changed the title [3.0] reset the client value of LazyConnectExchangeClient after close [3.0] set client to null at LazyConnectExchangeClient close functions Sep 23, 2021
@zrlw zrlw changed the title [3.0] set client to null at LazyConnectExchangeClient close functions [3.0] set client to null at LazyConnectExchangeClient close methods Sep 23, 2021
Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit d5ca09f into apache:3.0 Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants