Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] set client to null at LazyConnectExchangeClient close methods #8882

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 23, 2021

What is the purpose of the change

fix #8880 on master

  • set the client field of LazyConnectExchangeClient to null at the end of close() and close(int timeout) methods
  • move close status setting from HeaderExchangeChannel close(timeout) to close()

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #8882 (90868ed) into master (d1644b7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8882      +/-   ##
============================================
- Coverage     60.79%   60.77%   -0.02%     
- Complexity      446      449       +3     
============================================
  Files          1100     1100              
  Lines         44433    44435       +2     
  Branches       6471     6471              
============================================
- Hits          27011    27007       -4     
  Misses        14446    14446              
- Partials       2976     2982       +6     
Impacted Files Coverage Δ
...exchange/support/header/HeaderExchangeChannel.java 78.84% <100.00%> (-1.93%) ⬇️
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 58.06% <100.00%> (-0.18%) ⬇️
...c/protocol/dubbo/ReferenceCountExchangeClient.java 63.33% <100.00%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 53.57% <0.00%> (-3.58%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 83.05% <0.00%> (-3.39%) ⬇️
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 77.64% <0.00%> (-2.44%) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 61.42% <0.00%> (-2.15%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.37% <0.00%> (-1.12%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1644b7...90868ed. Read the comment docs.

@zrlw zrlw changed the title reset the client value of LazyConnectExchangeClient after close [master] reset the client value of LazyConnectExchangeClient after close Sep 23, 2021
@zrlw zrlw changed the title [master] reset the client value of LazyConnectExchangeClient after close [master] set client to null at LazyConnectExchangeClient close functions Sep 23, 2021
@zrlw zrlw changed the title [master] set client to null at LazyConnectExchangeClient close functions [master] set client to null at LazyConnectExchangeClient close methods Sep 23, 2021
@zrlw zrlw closed this Sep 27, 2021
@zrlw zrlw reopened this Sep 27, 2021
@AlbumenJ AlbumenJ merged commit b3120b5 into apache:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants