Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade logging jars due to security issues #9791

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Mar 16, 2022

What is the purpose of the change

Security concerns

#9792

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #9791 (9ff907b) into master (7cf49db) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9791      +/-   ##
============================================
- Coverage     60.89%   60.86%   -0.04%     
- Complexity      446      448       +2     
============================================
  Files          1100     1100              
  Lines         44546    44558      +12     
  Branches       6481     6486       +5     
============================================
- Hits          27126    27118       -8     
- Misses        14451    14475      +24     
+ Partials       2969     2965       -4     
Impacted Files Coverage Δ
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...ache/dubbo/qos/command/util/ServiceCheckUtils.java 6.89% <0.00%> (-4.87%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 57.14% <0.00%> (-4.29%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.18% <0.00%> (-3.61%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.79% <0.00%> (-1.13%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.37% <0.00%> (+0.74%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf49db...9ff907b. Read the comment docs.

@chickenlj chickenlj added this to the 3.0.7 milestone Mar 16, 2022
@chickenlj chickenlj merged commit da4f5f2 into apache:master Mar 16, 2022
@CrazyHZM CrazyHZM modified the milestones: 3.0.7, 2.7.16 Mar 16, 2022
@pjfanning pjfanning deleted the patch-1 branch March 16, 2022 09:24
@pjfanning pjfanning restored the patch-1 branch March 16, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants