Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0-Triple] Fix response type use hessian2 not hessian4 #9981

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Apr 29, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #9981 (02b4240) into 3.0 (5aa660c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                3.0    #9981   +/-   ##
=========================================
  Coverage     65.74%   65.75%           
+ Complexity      320      316    -4     
=========================================
  Files          1215     1215           
  Lines         53030    53040   +10     
  Branches       8032     8034    +2     
=========================================
+ Hits          34865    34874    +9     
+ Misses        14364    14355    -9     
- Partials       3801     3811   +10     
Impacted Files Coverage Δ
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 81.18% <100.00%> (-1.08%) ⬇️
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 79.59% <0.00%> (-12.25%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-9.10%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) ⬇️
...o/registry/nacos/util/NacosNamingServiceUtils.java 80.35% <0.00%> (-6.19%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 79.36% <0.00%> (-3.18%) ⬇️
.../dubbo/common/threadlocal/InternalThreadLocal.java 75.34% <0.00%> (-2.74%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 68.85% <0.00%> (-1.64%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa660c...02b4240. Read the comment docs.

@CrazyHZM CrazyHZM added this to the 3.0.8 milestone Apr 29, 2022
@guohao guohao merged commit bce439e into apache:3.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants