Fix overlapping in Speed Gauge #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the detail text (value and unit) in the Speed Gauge example overlaps with the pointer or gauge frame, especially for larger values.
Steps:
. Analyzed the issue in gauge-speed.ts to identify why the detail text overlaps with the pointer.
. Raised an #135
to track the problem.
Changes made:
. Adjusted detail.offsetCenter to improve vertical spacing
. Refined rich.value and rich.unit styles for better alignment
. Ensured the text remains centered and readable across all values
. Also i revert the changes which u mention in here PR 137
. Fixing the Bug of Thumbnail
Before Speed Guage:
After Speed Guage:
Impact:
. Improves readability and visual clarity in the Progress Gauge example.
. Ensures the official editor is consistent with local builds.
. Prevents confusion caused by overlapping detail text in gauges.