Skip to content

Conversation

@VedantPatil-99
Copy link

Fixes: #78

Description

This PR addresses several minor visual inconsistencies in the main navigation component (_components.nav.scss). The primary focus was on maintaining a consistent spacing in nav items.

Changes

  • Layout Cleanup: Removed legacy negative margins (-25px, -15px) from the #navbar-collapse element. These were causing the menu to bleed outside the container on some devices. Readded these margins in the media query (max-width: 768px)
  • Improved Spacing: Adjusted padding to 6px for screens between 768px and 900px. This prevents the navigation links from feeling crowded or wrapping prematurely on smaller tablet devices.
  • Fixed vertical alignment for active nav items.

Related Issue

Fixes #[Insert Issue Number Here]

Quality Check

  • Fixed vertical alignment for active nav items.
  • Verified responsive behavior on mobile (375px), tablet (768px), and desktop.
  • No regressions found in the dropdown menu behavior.

Screenshots (Optional but Recommended)

Before

echarts-expected-nav

After

echarts-expected-nav

Refine _components.nav.scss: adjust spacing and alignment, improve responsive behavior and hover/active states, remove unused variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Nav items spacing and alignment

1 participant