Merge pull request #13139 from easonyq/fix-13031

Fix: make `contentToOption` totally optional
apache · Aug 26, 2020 · 6af8923 · 6af8923
2 parents ed19857 + 13ae2d4
commit 6af8923
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/component/toolbox/feature/DataView.ts b/src/component/toolbox/feature/DataView.ts
@@ -371,6 +371,15 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
         addEventListener(closeButton, 'click', close);
 
         addEventListener(refreshButton, 'click', function () {
+            if ((contentToOption == null && optionToContent != null) ||
+                (contentToOption != null && optionToContent == null)) {
+                if (__DEV__) {
+                    console.warn('It seems you have just provided one of `contentToOption` and `optionToContent` functions but missed the other one. Data change is ignored.')
+                }
+                close();
+                return;
+            }
+
             let newOption;
             try {
                 if (typeof contentToOption === 'function') {