Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markline position inside grid area #11569

Closed
Ovilia opened this issue Nov 6, 2019 · 1 comment
Closed

Markline position inside grid area #11569

Ovilia opened this issue Nov 6, 2019 · 1 comment
Assignees
Labels
difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English new-feature priority: normal

Comments

@Ovilia
Copy link
Contributor

Ovilia commented Nov 6, 2019

What problem does this feature solve?

Currently, if set the position of markLine to be "left" or "right", it will go outside of the grid area. This may cause some bad influence when the grid area is near the edge of the Canvas.
I hope to get new position options to make them be positioned like the following design:
df952cda7e9f017dfa87f6d0fe3d5a72

What does the proposed API look like?

Previous valid values: 'start', 'middle', 'end'.
Proposed position names: 'start', 'middle', 'end', 'insideStartTop', 'insideStartBottom', 'insideMiddleTop', 'insideMiddleBottom', 'insideEndTop', 'insideEndBottom'.

@echarts-bot
Copy link

echarts-bot bot commented Nov 6, 2019

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.

If you are interested in the project, you may also subscribe our mail list.

Have a nice day! 🍵

@echarts-bot echarts-bot bot added en This issue is in English new-feature pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Nov 6, 2019
@Ovilia Ovilia removed pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Nov 6, 2019
@Ovilia Ovilia added this to the 4.7.0 milestone Nov 6, 2019
@Ovilia Ovilia added difficulty: easy Issues that can be fixed more easily than the average. priority: normal labels Nov 6, 2019
@Ovilia Ovilia self-assigned this Dec 10, 2019
@Ovilia Ovilia closed this as completed in 6aec55a Dec 19, 2019
alex2wong pushed a commit to alex2wong/incubator-echarts that referenced this issue Dec 21, 2019
alex2wong pushed a commit to alex2wong/incubator-echarts that referenced this issue Dec 21, 2019
alex2wong pushed a commit to alex2wong/incubator-echarts that referenced this issue Dec 21, 2019
@Ovilia Ovilia removed this from the 4.7.0 milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English new-feature priority: normal
Projects
None yet
Development

No branches or pull requests

1 participant