Grid border not closed at left-top corner (no z in SVG path)

[mindon]

Version

v5.1.1

Reproduction link

https://qp9zl.csb.app/

Steps to reproduce

render with option

const option = {
        grid: {
          show: true,
          borderWidth: 3,
          borderColor: "#000000"
        }
      };

What is expected?

corner closed

What is actually happening?

corner not closed

[echarts-bot]

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that it contains a minimum reproducible demo and necessary images to illustrate. Otherwise, our committers will ask you to do so.

A minimum reproducible demo should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.

You may also check out the API and chart option to get the answer.

If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.

If you are interested in the project, you may also subscribe our mailing list.

Have a nice day! 🍵

[plainheart]

I'm not sure why this commit ecomfe/zrender@da94b64 removed ctx.closePath(). @pissang

[pissang]

@plainheart I thought the first point and the last point has been connected in the roundRect.ts helper so there is no need to do closePath again, which is an extra cost in the case that drawing lots of rect(like in benchmark.html). But it seems to be a mistake in this case.

Also, only the SVG renderer that drawing a rectangle without border-radius will have this issue. Because canvas renderer will use ctx.rect command, which is closed underlying automatically. And drawing rectangle with border-radius also has no issue because there is an arc command connecting the first point and last point, which is like:

So I think what we need is adding an Z command when rendering rect command in the SVG renderer https://github.com/ecomfe/zrender/blob/9780bd81795010b7e99f77b907c7530552184942/src/svg/graphic.ts#L234
It can keep both performance in the canvas and correctness in the svg

[echarts-bot]

This issue is labeled with difficulty: easy.
@mindon Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

[plainheart]

@pissang Yes. I agree with you. That's right.