Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with width of markline #9598

Closed
ezubarev opened this issue Dec 17, 2018 · 7 comments · Fixed by OpenTMI/opentmi-default-gui#32 or DeviaVir/zenbot#2011 · May be fixed by dyna-dot/iClient-JavaScript-s#1
Closed

Bug with width of markline #9598

ezubarev opened this issue Dec 17, 2018 · 7 comments · Fixed by OpenTMI/opentmi-default-gui#32 or DeviaVir/zenbot#2011 · May be fixed by dyna-dot/iClient-JavaScript-s#1

Comments

@ezubarev
Copy link

Sometimes line width doesn't match provided settings.

markLine: {
    lineStyle: {
        normal: {
            type: 'solid',
            width: 1,
            color: 'black'
        },
    },
}

image

Two lines have the same configuration but the upper one is wider than lower one.

http://gallery.echartsjs.com/editor.html?c=xCUWInr4gz&v=1

Probably, you have to resize a window to reproduce it.

@pissang
Copy link
Contributor

pissang commented Dec 17, 2018

It's a common subpixel artifact in canvas when the pixel is not exactly on the x.5 position. We will add optimization in this case.

@ezubarev
Copy link
Author

Thank you, @pissang! Interesting to see how you will fix it in the code.

@deqingli
Copy link
Member

@ezubarev I have fixed the problem, you can see it with the associated commit.

@ezubarev
Copy link
Author

ezubarev commented Dec 19, 2018

Great! @deqingli, I have written some comments for your commit. Waiting for your explanations.

@ezubarev
Copy link
Author

ezubarev commented Aug 9, 2019

Bug has been reproduced in latest version. You should fix it again.

@ezubarev ezubarev reopened this Aug 9, 2019
@echarts-bot
Copy link

echarts-bot bot commented Aug 9, 2019

This issue is not created using issue template so I'm going to close it. 🙊
Sorry for this, but it helps save our maintainers' time so that more developers get helped.
Feel free to create another issue using the issue template.

这个 issue 未使用 issue 模板 创建,所以我将关闭此 issue。
为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
如果您愿意,可以请使用 issue 模板重新创建 issue。

@echarts-bot echarts-bot bot added the invalid label Aug 9, 2019
@echarts-bot echarts-bot bot closed this as completed Aug 9, 2019
@ezubarev
Copy link
Author

ezubarev commented Aug 9, 2019

@pissang @deqingli
Bug has been reproduced in latest version. You should fix it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment