fix(pie): add seriesId in pieselectchanged #9830 #10038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100pah
requested changes
Mar 4, 2019
| @@ -50,7 +50,8 @@ export default function (seriesType, actionInfos) { | |||
| ); | |||
| return { | |||
| name: payload.name, | |||
| selected: selected | |||
| selected: selected, | |||
| seriesId: payload.seriesId | |||
There was a problem hiding this comment.
payload probably has no seriesId, and the action probably effect multiple series.
dispatchAction({name: 'xxx'}); // Probably effect multiple series
dispatchAction({seriesName: 'xxx'}); // Probably effect multiple seriesI think we'd better discuss more about the further enhancement of properties of events, which currently is not good enough. Some properties are missing.
And also we should consider that some common properties (like seriesId seriesIndex componentIndex name) should be consistent as far as possible.
There was a problem hiding this comment.
I have checked it again and I think this fix is correct.
It can resolve the issue without negative effect to other cases.
The other cases can be discussed in future.
100pah
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
seriesIdfield inpieselectchangedevent.Fix #9830 .