Set progressiveThreshold and hoverLayerThreshold to Infinity #10635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100pah
requested changes
Jun 10, 2019
| @@ -67,15 +67,15 @@ export default { | |||
|
|
|||
| animationThreshold: 2000, | |||
| // Configuration for progressive/incremental rendering | |||
| progressiveThreshold: 3000, | |||
| progressiveThreshold: Infinity, | |||
There was a problem hiding this comment.
TreemapSeries has disabled progressive by setting progressive: 0 by default.
| progressive: 400, | ||
|
|
||
| // Threshold of if use single hover layer to optimize. | ||
| // It is recommended that `hoverLayerThreshold` is equivalent to or less than | ||
| // `progressiveThreshold`, otherwise hover will cause restart of progressive, | ||
| // which is unexpected. | ||
| // see example <echarts/test/heatmap-large.html>. | ||
| hoverLayerThreshold: 3000, | ||
| hoverLayerThreshold: Infinity, |
There was a problem hiding this comment.
I think The default hoverLayerThreshold should not be simply set Infinity.
I think we should find a better solution in updateHoverLayerStatus
100pah
added a commit
that referenced
this pull request
Jun 10, 2019
100pah
added a commit
that referenced
this pull request
Jun 10, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to this issue.
For now I just point out problem, finally solution still need to decide.
#10521