Add clip option for line, bar, lines, scatter, custom series #11283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in recorder page.
100pah
approved these changes
Sep 19, 2019
| layout.width = x2 - x; | ||
| layout.height = y2 - y; | ||
|
|
||
| var clipped = layout.width < 0 || layout.height < 0;; |
| this.group.setClipPath(clipPath); | ||
| } | ||
| else { | ||
| this.group.removeClipPath(null); |
There was a problem hiding this comment.
null is not needed.
It seems that removeClipPath has no arg.
There was a problem hiding this comment.
Thanks @100pah . I will fix it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request about adding clip option for line, bar, lines, scatter and custom series.
More details can be found in the issue #11240
Test Case
https://github.com/apache/incubator-echarts/blob/feature/clip/test/clip.html
Test result compared to 4.2.1
The result is generated with Visual Regression Testing Tool.
You can run it by the following command: