fix(toolbox): optimize stack icon toggle experience. #12360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge some commits from apache/master
… `tiled` if stack is not enabled. close apache#12359.
|
Thanks for your contribution! The pull request is marked to be |
plainheart
changed the title
magictypechanged should be the type tiled if stack is not enabled. close #12359.magictypechanged should return the type tiled if stack is not enabled. close #12359.
plainheart
changed the title
magictypechanged should return the type tiled if stack is not enabled. close #12359.magictypechanged should return the type tiled if stack is not enabled. close #12359.
plainheart
changed the title
magictypechanged should return the type tiled if stack is not enabled. close #12359.
plainheart
changed the title
pissang
requested changes
Aug 4, 2020
| var iconPaths = featureModel.iconPaths = {}; | ||
| zrUtil.each(icons, function (iconStr, iconName) { | ||
| // `tiled` is just for changing stack toggle icon, no need to add a path. | ||
| if (isMagicType && iconName === 'tiled') { | ||
| return; |
There was a problem hiding this comment.
It's better to put this logic in the render and updateView method of MagicType.js. ToolboxView should be not aware of what features it may have.
brush feature is a typical example: https://github.com/apache/incubator-echarts/blob/next/src/component/toolbox/feature/Brush.ts#L47
You may refactor it in the next branch if you wish
|
Do it in 5.0. |
What's the release date of 5.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
currentTypeinmagictypechangedevent should betiled(Magictype Event #12359)Fixed issues
Related test cases
Test case: refer to
test/toolbox-stackTiledToggle.html