Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bar-race): label animation #13045

Merged
merged 5 commits into from
Jul 30, 2020
Merged

fix(bar-race): label animation #13045

merged 5 commits into from
Jul 30, 2020

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jul 29, 2020 •
edited
Loading

See #12484 for more details.

This PR fixes:

  • Label interpolation animation when calling setOption for multiple times
  • Sort first before filtering with axis min and max
  • Bugs when merged with the current next branch
  • Bugs when bars out-of-sight going into sight

@echarts-bot
Copy link

echarts-bot bot commented Jul 29, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia changed the base branch from master to next July 29, 2020 11:13
@Ovilia Ovilia changed the title fix(bar-race): label animation WIP fix(bar-race): label animation Jul 29, 2020
@Ovilia Ovilia changed the title WIP fix(bar-race): label animation fix(bar-race): label animation Jul 30, 2020
@pissang pissang merged commit 5dc6e37 into next Jul 30, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jul 30, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat-bar-race branch July 31, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ovilia @pissang @plainheart