-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] [Feature] support largest-triangle-three-buckets algo #13317
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the |
/** | ||
* Large data down sampling using largest-triangle-three-buckets | ||
* copied from https://github.com/pingec/downsample-lttb with some modifications | ||
* @param {string} baseDimension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the code directly. It will have a license issue.
If you are sure that the code is definitely different. You should avoid using terms like copy from
, Referencing
, etc. in the comment.
Also, do you mind adding a test case to compare the result and performance difference between lttb sampling enabled and disabled? The example used in #13314 (comment) will be a good case. And there are some code style like inconsistent indentation needs to be fixed. |
@pissang Thank you for your advise. I added comparison of results in
Fixed. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Support largest-triangle-three-buckets sampling algorithm.
Fixed issues
#9403
Usage
Are there any API changes?
sampling: 'lttb'
Related test cases or examples to use the new APIs
See test/line-large.html line 101.
Others
Merging options
Other information
In master branch it works, see #13312.
But in next branch, because of #12997 , samplers doesn't run in some cases.
And when it run, there is a point highlight bug, I think it's better to fix those bugs in other pr.