Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] [Feature] pie series supports cornerRadius & innerCornerRadius. #13378

Merged
merged 8 commits into from
Oct 6, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Sep 30, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Pie series supports corner radius in ECharts, please refer to #13123 & ecomfe/zrender#643 for more details.

Fixed issues

Details

image

image

image

image

image

Usage

Are there any API changes?

  • The API has been changed.

Added a new option to the pie series.

  • cornerRadius (can be a string/number/string array/number array)

Related test cases or examples to use the new APIs

Please refer to test/pie-cornerRadius.html.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

TODO: Whether to support corner radius for bar series with the polar coordinate, currently there is an option itemStyle.barBorderRadius, but it is only for the cartesian2d coordinate. (If needed, we could implement it later).

#13390- Sunburst series supports cornerRadius
fe0d94a - Treemap series supports borderRadius

@echarts-bot
Copy link

echarts-bot bot commented Sep 30, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pissang
Copy link
Contributor

pissang commented Oct 6, 2020

Wow!!

@pissang pissang merged commit a088d80 into apache:next Oct 6, 2020
@echarts-bot
Copy link

echarts-bot bot commented Oct 6, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the feat-pie-corner-radius branch December 25, 2020 07:17
@apache apache deleted a comment from echarts-bot bot Sep 23, 2022
@plainheart plainheart added PR: doc ready and removed PR: awaiting review PR: awaiting doc Document changes is required for this PR. labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants