-
Notifications
You must be signed in to change notification settings - Fork 19.8k
feat(brush): user can provide cursor style. close #13712 #14371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the |
|
Thanks for your help, but first, please do not commit any file in |
|
Alright @susiwen8 |
Should I revert the changes in I'm just starting the contributions, thanks for your help. |
|
|
When does the PR get reviewed? |
|
@g7i Thanks, it's planned in 5.2.0 |
|
@pissang @plainheart @susiwen8 I have resolved the conflicts, so its ready to be reviewed. Thanks... |
Brief Information
This pull request is in the type of:
What does this PR do?
User can now provide cursor style when mouse is inside and outside the brush.
Fixed issues
close #13712 : Support cursor option in brush
Details
Added field
cursorfor cursor style ininBrushandoutOfBrush.Before: What was the problem?
Earlier there was default cursor for brush ie crosshair for out of the brush and move for within the brush. User was unable to customize that.
After: How is it fixed in this PR?
User can now provide cursor style when mouse is inside and outside the brush. Added field
cursorfor cursor style ininBrushandoutOfBrush.Usage
User can now provide cursor style when mouse is inside and outside the brush.
Are there any API changes?
Related test cases or examples to use the new APIs
Check
brush.htmlfile intestdir.Others
Merging options
Other information