Skip to content

Conversation

@g7i
Copy link
Contributor

@g7i g7i commented Feb 28, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

User can now provide cursor style when mouse is inside and outside the brush.

Fixed issues

close #13712 : Support cursor option in brush

Details

Added field cursor for cursor style in inBrush and outOfBrush.

Before: What was the problem?

Earlier there was default cursor for brush ie crosshair for out of the brush and move for within the brush. User was unable to customize that.

After: How is it fixed in this PR?

User can now provide cursor style when mouse is inside and outside the brush. Added field cursor for cursor style in inBrush and outOfBrush.

Usage

User can now provide cursor style when mouse is inside and outside the brush.

Are there any API changes?

  • The API has been changed.
- Added field `cursor` for cursor style in `inBrush` and `outOfBrush`.

Related test cases or examples to use the new APIs

Check brush.html file in test dir.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 28, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Feb 28, 2021
@susiwen8
Copy link
Contributor

Thanks for your help, but first, please do not commit any file in dist, only src.

@g7i
Copy link
Contributor Author

g7i commented Feb 28, 2021

Alright @susiwen8

@g7i
Copy link
Contributor Author

g7i commented Feb 28, 2021

Thanks for your help, but first, please do not commit any file in dist, only src.

Should I revert the changes in dist dir and push a new commit?

I'm just starting the contributions, thanks for your help.

@susiwen8
Copy link
Contributor

Should I revert the changes in dist dir and push a new commit?
Yes, you could.

@g7i
Copy link
Contributor Author

g7i commented Mar 11, 2021

When does the PR get reviewed?

@pissang pissang added this to the 5.2.0 milestone Mar 12, 2021
@pissang
Copy link
Contributor

pissang commented Mar 12, 2021

@g7i Thanks, it's planned in 5.2.0

@g7i
Copy link
Contributor Author

g7i commented Jul 15, 2021

@pissang @plainheart @susiwen8 I have resolved the conflicts, so its ready to be reviewed. Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support cursor option in brush

4 participants