Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong jpg instead of jpeg image export types #16747

Merged
merged 1 commit into from
Mar 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/component/toolbox/feature/SaveAsImage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { isFunction } from 'zrender/src/core/util';
export interface ToolboxSaveAsImageFeatureOption extends ToolboxFeatureOption {
icon?: string
title?: string
type?: 'png' | 'jpg'
type?: 'png' | 'jpeg'

backgroundColor?: ZRColor
connectedBackgroundColor?: ZRColor
Expand Down
4 changes: 2 additions & 2 deletions src/core/echarts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ class ECharts extends Eventful<ECEventDefinition> {

getDataURL(opts?: {
// file type 'png' by default
type?: 'png' | 'jpg' | 'svg',
type?: 'png' | 'jpeg' | 'svg',
pixelRatio?: number,
backgroundColor?: ZRColor,
// component type array
Expand Down Expand Up @@ -807,7 +807,7 @@ class ECharts extends Eventful<ECEventDefinition> {

getConnectedDataURL(opts?: {
// file type 'png' by default
type?: 'png' | 'jpg' | 'svg',
type?: 'png' | 'jpeg' | 'svg',
pixelRatio?: number,
backgroundColor?: ZRColor,
connectedBackgroundColor?: ZRColor
Expand Down