fix(scale): intervalTick should between extent. close 16888 #16963
Conversation
|
Thanks for your contribution! |
|
Thanks! Could you add a test case for this? |
done.
|
|
|
||
| const levelsTicksInExtent = filter(map(levelsTicks, levelTicks => { | ||
| return filter(levelTicks, tick => tick.value >= extent[0] && tick.value <= extent[1] && !tick.notAdd); | ||
| return filter(levelTicks, tick => tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd); |
There was a problem hiding this comment.
This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in timeScale-formatter.html still works the same as before changing.
There was a problem hiding this comment.
This is probably not the correct place to fix the problem. For example, the min/max labels are always hidden after this changing. You need to make sure the test cases in
timeScale-formatter.htmlstill works the same as before changing.
min/max labels work normal after this changing, could you check it again? Or give me a specific example ?
@Ovilia
test/axisLabel.html
Outdated
| backgroundColor: '#eee', | ||
| title: { | ||
| text: 'axisLable.formatter: {value} should be correct' | ||
| text: 'axisLabel.formatter: {value} should be correct' |
There was a problem hiding this comment.
Related test cases should be put into timeScale-formatter.html
There was a problem hiding this comment.
related test case has been move into timeScale-formaatter.html
@Ovilia
|
min/max labels work normal after this changing, could you check it again? Or give me a specific example ? |
1 similar comment
|
min/max labels work normal after this changing, could you check it again? Or give me a specific example ? |
MeetzhDing
force-pushed
the
fix-16888
branch
from
dcc7d54 to
0dea57c
Compare
|
+1 Any news if |
4 participants
Brief Information
This pull request is in the type of:
What does this PR do?
filter intervalTick by
tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd;Fixed issues
#16888
xAxis[type=time], set showMinLabel=false not work
Details
Before: What was the problem?