Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): draggable only work on force layout #17792

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

kongmoumou
Copy link
Contributor

@kongmoumou kongmoumou commented Oct 19, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

PR #15428 enable draggable for all layout(could test in test/graph-draggable.html), but #16867 maybe override the flag unintentionally resulting that draggable only work on layout: force.

This pr fix it.

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 19, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@Ovilia
Copy link
Contributor

Ovilia commented Oct 25, 2022

@kongmoumou Could you please explain what situation this PR fixes? You may need to add them in the test files.

@kongmoumou
Copy link
Contributor Author

@Ovilia added the following explaination

PR #15428 enable draggable for all layout(could test in test/graph-draggable.html), but #16867 maybe override the flag unintentionally resulting that draggable only work on layout: force.

@Ovilia Ovilia merged commit 0a5d50a into apache:master Oct 27, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 27, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.4.1 milestone Oct 27, 2022
@plainheart plainheart removed this from the 5.4.1 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants