feat(legend): add legendmouseover legendmouseout event (#18144) #18164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: awaiting doc
|
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
|
Waiting for review |
Ovilia
requested changes
Nov 6, 2024
src/component/legend/legendAction.ts
Outdated
| @@ -37,6 +37,9 @@ function legendSelectActionHandler(methodName, payload, ecModel) { | |||
| else if (methodName === 'allSelect' || methodName === 'inverseSelect') { | |||
| legendModel[methodName](); | |||
| } | |||
| else if (methodName === 'legendMouseover' || methodName === 'legendMouseout') { | |||
| isSelected = legendModel.isSelected(payload.name); | |||
There was a problem hiding this comment.
This is perhaps no longer needed. You make merge the current master code and have a double check.
There was a problem hiding this comment.
You should update the LegendSelectMethodNames after merging from master.
sz-p
force-pushed
the
add-legend-mouse-event
branch
from
4a0eebc
to
eb975b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
add legend event
legendmouseoverlegendmouseoutFixed issues
#18144
Details
Before: What was the problem?
Stop data carousel when mouse hover on legend must customizing legend elements with HTML
see demo:
https://codepen.io/plainheart/pen/xxJRdam
After: How does it behave after the fixing?
Stop data carousel with legend event
legendmouseoverlegendmouseoutsee demo:
https://stackblitz.com/edit/js-q9vzb5?file=index.js
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information