Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): fix tree update error with animation and without animation #18491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. For polyline, with animation on, to filter out nodes that are about to exit, and clear sourceEdge if the number of remaining nodes is 0
  2. For all tree, with animation off, pass the current node in removeNodeEdge since the current node is immediately deleted, making it impossible to get the current node by dataIndex.

Fixed issues

Details

Before: What was the problem?

  1. For polyline, when a child node is removed by updating the node, the line is not removed
  2. For all trees, when collapsing a node with animation off, lines will be left behind

After: How does it behave after the fixing?

  1. for polyline, when a child node is removed by updating the node, the lines will be removed
  2. For all trees, collapse the node with the animation off, no lines will be left

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 10, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! This fixes an important bug of Tree Series.

src/chart/tree/TreeView.ts Outdated Show resolved Hide resolved
src/chart/tree/TreeView.ts Outdated Show resolved Hide resolved
@Rubp-007
Copy link

Rubp-007 commented May 9, 2024

@Ovilia When will this PR be reviewed? It's been almost a year now and the bug persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants