Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie): add endAngle for control pie range #18820

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jun 28, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

add angel range to implement half pie.

Fixed issues

Details

Before: What was the problem?

If I want a half pie seies, I have to calculate total, to create a transparent sector shape

image

After: How does it behave after the fixing?

Add a attribute to control pie angel range, so I can show a half pie series just write options like this

image

you will get pie series like this

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#351

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jun 28, 2023
@echarts-bot
Copy link

echarts-bot bot commented Jun 28, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghaoSu I noticed that you have contributed a lot lately and thanks for that!

src/chart/pie/PieSeries.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18820@65d7442

@linghaoSu linghaoSu changed the title feat(pie): add angleRange for control pie range feat(pie): add endAngle for control pie range Jun 29, 2023
@linghaoSu linghaoSu requested a review from Ovilia June 29, 2023 15:35
src/chart/pie/pieLayout.ts Outdated Show resolved Hide resolved
src/chart/pie/pieLayout.ts Outdated Show resolved Hide resolved
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Jul 3, 2023
@linghaoSu linghaoSu requested a review from Ovilia July 3, 2023 05:14
@plainheart plainheart added this to the 5.5.0 milestone Jul 3, 2023
src/chart/pie/pieLayout.ts Show resolved Hide resolved
@Ovilia Ovilia merged commit b79777e into apache:master Jul 4, 2023
@echarts-bot
Copy link

echarts-bot bot commented Jul 4, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants