fix(sankey): fix sankey line color 'target'/'source'/'gradient' doesn't work in non-normal state
#18834
+144
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18834@f22ee7e |
plainheart
reviewed
Jul 1, 2023
plainheart
reviewed
Jul 1, 2023
linghaoSu
force-pushed
the
fix/sankey-emphasis
branch
from
3e86015
to
f22ee7e
Compare
plainheart
approved these changes
Jul 1, 2023
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
changed the title
'target'/'source'/'gradient' doesn't work in non-normal state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix sankey emphsis lineStyle color is not a normal color, using node color(
source,target,gradient)Fixed issues
emphasis.lineStyle.color: 'target'not work #18804Details
Before: What was the problem?
not parse color in emphsis lineStyle (source,target or gradient), so using a default color
After: How does it behave after the fixing?
Using logic in normal state to parse color(
target,sourceorgradient), apply that to other state.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information