Skip to content

Conversation

@zhaxnb
Copy link
Contributor

@zhaxnb zhaxnb commented Jan 15, 2024

…ng default boundaryGap configuration.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed using the toolbox to change line or bar charts but without using default boundaryGap configuration.

Fixed issues

Details

Before: What was the problem?

using the toolbox to change line or bar charts but without using default boundaryGap configuration.

After: How does it behave after the fixing?

start
image
before
image
after
image

change
image
image

official website demo
image
image

official demo
modify xAxis->boundaryGap: fasle to boundaryGap: true, click run then click switch to line chart.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jan 15, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@zhaxnb
Copy link
Contributor Author

zhaxnb commented Jan 15, 2024

last pr #19428 is broken. this is new.

@plainheart plainheart changed the title fix: fix using the toolbox to change line or bar charts but without u… fix(toolbox): use default boundaryGap when switching the line & bar series by the toolbox component Jan 15, 2024
@plainheart plainheart added this to the 5.5.0 milestone Jan 15, 2024
@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19509@89007be

@Ovilia Ovilia modified the milestones: 5.5.0, 5.5.1 Jan 18, 2024
@apache apache deleted a comment from gooroodev Jun 9, 2024
@apache apache deleted a comment from admsev Jun 9, 2024
@plainheart plainheart added the discussion-required Further discussion is required before we decide if this issue should be fixed. label Jun 11, 2024
@Ovilia Ovilia modified the milestones: 5.5.1, 5.5.2 Jun 28, 2024
@plainheart plainheart modified the milestones: 5.5.2, 6.0.0 Nov 11, 2024
@Ovilia Ovilia modified the milestones: 6.0.0, 6.x Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion-required Further discussion is required before we decide if this issue should be fixed. PR: awaiting review PR: doc unchanged size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants