Skip to content

Conversation

@plainheart
Copy link
Member

@plainheart plainheart commented Dec 20, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a regression bug that marker fails to render with dataset and encode due to storeDimIndex mismatch. This bug was introduced in #20682.

Fixed issues

Comparison

Before After
image image
image image
image image

VRT

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

See test/marker-dataset-encode.html

Merging options

  • Please squash the commits into a single one when merging.

Other information

…o storeDimIndex mismatch.

This regression was introduced in #20682
@echarts-bot
Copy link

echarts-bot bot commented Dec 20, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21439@4d3fff8

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 21, 2025
@100pah 100pah merged commit 59f3f9a into release Dec 21, 2025
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Dec 21, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/marker-dataset branch December 22, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 当使用dataset时,markline会报错 [Bug] candlestick chart combined with markLine exception

2 participants