fix: slider background should respect borderRadius property #21447
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This pull request fixes a visual bug where the slider dataZoom component's background color does not respect the
borderRadiusconfiguration option. The fix ensures that whenborderRadiusis specified, the background rectangle is properly clipped to match the rounded corners.Fixed issues
Details
Before: What was the problem?
When using the slider dataZoom component with both
backgroundColorandborderRadiusconfigured, the background color would extend beyond the defined border radius, creating a visual inconsistency. The rounded corners were applied to some elements but not to the background rectangle, resulting in the background "bleeding" outside the intended bounds.The background rectangle was created without the
r(radius) property in the shape configuration, causing it to ignore theborderRadiussetting.After: How does it behave after the fixing?
The background rectangle now properly respects the
borderRadiusconfiguration. The fix retrieves theborderRadiusvalue from the dataZoomModel and applies it to the shape'srproperty, ensuring consistent rounded corners across all visual elements of the slider.Implementation details:
const borderRadius = dataZoomModel. get('borderRadius')to retrieve the configuration valuer: borderRadiusto the Rect shape properties to apply the border radiusThe fix is minimal (2 lines) and follows the existing pattern used in other parts of the codebase where border radius is applied to shapes.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N/A - This is a bug fix for existing functionality. The
borderRadiusoption already exists in the dataZoom configuration; this fix simply ensures it's applied to the background element.Merging options