-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #97] Runtime tcp http grpc client impl #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly refer to the standard title format used in other PRs.
Do you have any question on the implementation of Operation classes? |
This pr has grpc version conflicts. |
Can it be fixed? Is some major modification required? |
I'll try to fix it, but I'm not sure if it can be done because the grpc version between eventmesh-sdk and jetcd is not compatible, I've looked at the various versions of jetcd for the grpc version, and it's not the same as the eventmesh-sdk grpc version, and I'm not sure if upgrading the grp version will make both sides compatible, I'll try to do it that way, otherwise I think we should prioritise securing the runtime client implementation. |
We may discard etcd implementation by now since nacos is the recommended one. |
No, they look good to me |
@Alonexc It seems that test is blocked because Github Action doesn't have working enviroment. |
Do you mean adding paths-ignore paths in ci? |
Added etcd connecttime , but it didn't build successfully, I commented out the test code for etcd and will follow up to fix the problem, local testing of the client test for etcd is fine. |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Alonexc It seems Runtime's grpc version is too old. You can't even download its source code in IDEA. |
Fixes #97
Motivation
runtime tcp http grpc client impl
Modifications
runtime tcp http grpc client impl
Documentation