Skip to content

Conversation

fabian4
Copy link
Member

@fabian4 fabian4 commented Aug 27, 2023

Fixes #4403.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Fix the SPI extension admin-api loading of eventmesh-storage-redis

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@fabian4 fabian4 changed the title Fix redis admin spi [ISSUE #4403] Fix redis admin spi Aug 27, 2023
@fabian4 fabian4 requested a review from Pil0tXia August 27, 2023 07:37
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #4405 (bbfb55a) into master (3678c23) will decrease coverage by 0.05%.
Report is 3 commits behind head on master.
The diff coverage is 0.71%.

❗ Current head bbfb55a differs from pull request most recent head 405f4b8. Consider uploading reports for the commit 405f4b8 to get more accurate results

@@             Coverage Diff              @@
##             master    #4405      +/-   ##
============================================
- Coverage     17.82%   17.77%   -0.05%     
- Complexity     1514     1515       +1     
============================================
  Files           604      613       +9     
  Lines         25559    25632      +73     
  Branches       2400     2377      -23     
============================================
+ Hits           4556     4557       +1     
- Misses        20564    20636      +72     
  Partials        439      439              
Files Changed Coverage Δ
...e/admin/handler/RedirectClientByIpPortHandler.java 34.04% <0.00%> (ø)
...dmin/handler/RedirectClientBySubSystemHandler.java 9.09% <0.00%> (ø)
.../runtime/admin/handler/RejectAllClientHandler.java 12.50% <0.00%> (ø)
...ime/admin/handler/RejectClientByIpPortHandler.java 9.30% <0.00%> (ø)
.../admin/handler/RejectClientBySubSystemHandler.java 8.33% <0.00%> (ø)
...ntmesh/runtime/admin/handler/TCPClientHandler.java 4.54% <0.00%> (-0.06%) ⬇️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.68% <0.00%> (+0.16%) ⬆️
...eventmesh/runtime/boot/EventMeshHttpBootstrap.java 0.00% <0.00%> (ø)
...apache/eventmesh/runtime/boot/EventMeshServer.java 0.00% <0.00%> (ø)
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.84% <0.00%> (+0.27%) ⬆️
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please create a seperate issue.

@xwm1992 xwm1992 merged commit fbbb81d into apache:master Aug 29, 2023
@fabian4 fabian4 deleted the fix_redis_admin_spi branch August 29, 2023 12:56
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the SPI extension admin-api loading of storage-plugins
5 participants