FELIX-6741 Upgrade dependencies for maven-bundle-plugin #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade all dependencies, including bnd 7.1.0
…s-for-maven-bundle-plugin
- Reset maven version to 3.3.9, as specified in bnd 7.1.0 changelog - Fix tests; add build timestamp greater than 1980 (required in new maven-archiver) - Fix tests; change bnd version
- Don't lower maven version used earlier
- Add integration test for Export-Package / Import-Package, based on bndtools/bnd#6270 - This is backwards compatible, as maven-bundle-plugin automatically adds a version for all Export-Package statements if not specified (1.0.0) These instructions: ``` <Export-Package>org.apache.felix.test1,org.apache.felix.test2;version="1-SNAPSHOT"</Export-Package> <Import-Package>org.apache.felix.test1,org.apache.felix.test2</Import-Package> ``` Lead to these manifest entries: ``` Export-Package: org.apache.felix.test1;version="1.0.0",org.apache.felix. test2;version="1.0.0.SNAPSHOT" Import-Package: org.apache.felix.test1,org.apache.felix.test2;version="[ 1.0,2)" ```
|
I made some additional changes and added a integration test for bndtools/bnd#6270, to verify impact on the maven-bundle-plugin (there is no impact). This PR is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will first test this release myself before merging it, as the bnd 7.1.0 mentions a change that might be relevant / no longer backwards compatible. See https://github.com/bndtools/bnd/wiki/Changes-in-7.1.0#bnd