Confirm existance of elements before accessing them

apache · Dec 30, 2024 · 07b94e7 · 07b94e7
1 parent 23850a1
commit 07b94e7
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/...ct-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java b/...ct-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
@@ -1594,12 +1594,19 @@ public void validateAccountBalanceDoesNotBecomeNegative(final String transaction
     public void validateAccountBalanceDoesNotViolateOverdraft(final List<SavingsAccountTransaction> savingsAccountTransaction,
             final BigDecimal amountPaid) {
         if (savingsAccountTransaction != null) {
-            SavingsAccountTransaction savingsAccountTransactionFirst = savingsAccountTransaction.get(0);
-            if (!this.allowOverdraft) {
-                if (savingsAccountTransactionFirst.getRunningBalance(this.currency).minus(amountPaid).isLessThanZero()) {
+            if (savingsAccountTransaction.size() > 0) {
+                SavingsAccountTransaction savingsAccountTransactionFirst = savingsAccountTransaction.get(0);
+                if (!this.allowOverdraft) {
+                    if (savingsAccountTransactionFirst.getRunningBalance(this.currency).minus(amountPaid).isLessThanZero()) {
+                        throw new InsufficientAccountBalanceException("transactionAmount", getAccountBalance(), null, amountPaid);
+                    }
+                }
+            } else {
+                if (!this.allowOverdraft) {
                     throw new InsufficientAccountBalanceException("transactionAmount", getAccountBalance(), null, amountPaid);
                 }
             }
+
         }
     }