-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-2023: Improve contributor's guide #3765
base: develop
Are you sure you want to change the base?
FINERACT-2023: Improve contributor's guide #3765
Conversation
b7ad988
to
16f38ac
Compare
16f38ac
to
81f53db
Compare
|
||
* Browse existing link:https://issues.apache.org/jira/browse/FINERACT-2055?jql=project%20%3D%20FINERACT%20ORDER%20BY%20created%20DESC[issues] | ||
** Filter by tags - "volunteer", "gsoc", "new contributor", etc. | ||
* Browse link:https://mifosforge.jira.com/wiki/spaces/RES/pages/3532095546/Google+Summer+of+Code+2024+Ideas[GSoC projects] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot point to an external project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -0,0 +1,3 @@ | |||
= VIDEO DEMONSTRATION | |||
|
|||
Apache Fineract / Mifos X Demo (November 2016) - <https://www.youtube.com/watch?v=h61g9TptMBo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really old. Let's delete or create a new one. I think it should be a demo of the APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdailey Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes I think are needed.
6be8a8e
to
d34fcb5
Compare
d34fcb5
to
79d71e9
Compare
agreed. I've made the changes now |
@abhinav7sinha Please fix the conflicts (rebase your PR) and squash the commits! |
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Is this stale? What changes are needed to accept this? |
@abhinav7sinha is this something that you are still open to finishing, I am looking to make contributions to the documentation mainly finishing the TBD sections and i think a lot of the work is already done here. If you are open to someone else taking over these changes and getting them in please let me know |
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.