Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2021: refactor the note GET end-points to use Jackson instead of GSON. #3915

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Zeyad2003
Copy link
Contributor

@Zeyad2003 Zeyad2003 commented Jun 5, 2024

Description

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@vidakovic
Copy link
Contributor

@Zeyad2003 let's organize a call... I have some more information for you. Let's leave this PR for the moment as it is, please do not merge.

@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from 1864b4e to 4e823ce Compare June 6, 2024 11:38
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from 4e823ce to 500702c Compare June 18, 2024 17:44
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 4 times, most recently from 6c1a49b to d8bcf0f Compare June 19, 2024 12:50
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 2 times, most recently from a18e9a2 to 8ce9d8f Compare June 21, 2024 09:27
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from 8ce9d8f to 937fd43 Compare June 21, 2024 12:11
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 13 times, most recently from df4bc00 to 2d4f312 Compare June 25, 2024 01:54
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 8 times, most recently from d0e1c4e to b6fd5fa Compare July 28, 2024 08:48
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 8 times, most recently from 8e8fef3 to 0c04a7e Compare July 31, 2024 22:17
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 4 times, most recently from 2adb163 to b715704 Compare August 8, 2024 01:32
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch 2 times, most recently from 2903b5b to 8e2db2a Compare August 19, 2024 13:00
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from 8e2db2a to c637627 Compare August 20, 2024 17:56
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from c637627 to e213868 Compare August 29, 2024 13:47
…erialization with GSON.

- Implemented a new custom module for the note API.
- Used Spring Web-MVC annotations instead of JAX-RS.
- Dispensed the redundant query parameters like "fields, prettyPrint ..etc"
- Implemented a new `CommonWebConfiguration` for establishing the security configurations (not complete yet).
- Implemented configuration modules (core, starter, configuration) for configuring the note module.
- Implemented a new `docker-compose-api-v3.yml` configuration file.
@Zeyad2003 Zeyad2003 force-pushed the FINERACT-2021/refactor_GET_Methods branch from e213868 to b0a4077 Compare September 1, 2024 22:03
@Zeyad2003
Copy link
Contributor Author

@vidakovic

What should be done with this PR?
It contains the read requests work and the setup for the project (e.g. docker-compose-api-v3.yml).
Also, the other PR for write requests (#3994) depends on it.

Copy link

github-actions bot commented Oct 6, 2024

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants