FINERACT-2021: refactor the note GET end-points to use Jackson instead of GSON. #3915
+681
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zeyad2003 let's organize a call... I have some more information for you. Let's leave this PR for the moment as it is, please do not merge. |
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
1864b4e
to
4e823ce
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
4e823ce
to
500702c
Compare
Zeyad2003
commented
Jun 19, 2024
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
4 times, most recently
from
6c1a49b
to
d8bcf0f
Compare
Zeyad2003
commented
Jun 19, 2024
custom/gsoc/note/api/src/main/java/org/apache/fineract/gsoc/note/api/NoteApiController.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jun 19, 2024
custom/gsoc/note/api/src/main/java/org/apache/fineract/gsoc/note/api/NoteApiController.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jun 19, 2024
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
2 times, most recently
from
a18e9a2
to
8ce9d8f
Compare
Zeyad2003
commented
Jun 21, 2024
.../src/main/java/org/apache/fineract/typesafe/common/configuration/CommonWebConfiguration.java
Outdated
Show resolved
Hide resolved
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
8ce9d8f
to
937fd43
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
13 times, most recently
from
df4bc00
to
2d4f312
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
8 times, most recently
from
d0e1c4e
to
b6fd5fa
Compare
6 tasks
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
8 times, most recently
from
8e8fef3
to
0c04a7e
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
4 times, most recently
from
2adb163
to
b715704
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
2 times, most recently
from
2903b5b
to
8e2db2a
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
8e2db2a
to
c637627
Compare
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
c637627
to
e213868
Compare
…erialization with GSON. - Implemented a new custom module for the note API. - Used Spring Web-MVC annotations instead of JAX-RS. - Dispensed the redundant query parameters like "fields, prettyPrint ..etc" - Implemented a new `CommonWebConfiguration` for establishing the security configurations (not complete yet). - Implemented configuration modules (core, starter, configuration) for configuring the note module. - Implemented a new `docker-compose-api-v3.yml` configuration file.
Zeyad2003
force-pushed
the
FINERACT-2021/refactor_GET_Methods
branch
from
e213868
to
b0a4077
Compare
|
What should be done with this PR? |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.