FINERACT-1981: Pay-off does not consider the overdue installments #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Oct 29, 2024
| @@ -281,7 +281,7 @@ public OutstandingAmountsDTO calculatePrepaymentAmount(MonetaryCurrency currency | |||
| .interest(result.getPayableInterest()); | |||
|
|
|||
| installments.forEach(installment -> amounts // | |||
| .plusFeeCharges(installment.getFeeChargesOutstanding(currency)) | |||
| .plusInterest(installment.getInterestOutstanding(currency)).plusFeeCharges(installment.getFeeChargesOutstanding(currency)) | |||
There was a problem hiding this comment.
We should only consider the outstanding interest from past due installment. During pay-off / prepayment we dont want the customer to pay future interests.
kulminsky
force-pushed
the
FINERACT-1981/pay_off_doesnt_consider_the_overdue_installments
branch
from
5f21568
to
164215b
Compare
adamsaghy
reviewed
Oct 29, 2024
| @@ -280,6 +280,9 @@ public OutstandingAmountsDTO calculatePrepaymentAmount(MonetaryCurrency currency | |||
| .principal(result.getOutstandingBalance()) // | |||
| .interest(result.getPayableInterest()); | |||
|
|
|||
| installments.stream().filter(installment -> installment.getDueDate().isBefore(onDate) || installment.getDueDate().isEqual(onDate)) | |||
There was a problem hiding this comment.
I am afraid the || installment.getDueDate().isEqual(onDate) is still incorrect as if the onDate is on the same day as the installment due date, that means that is the "actual" installment and we already calculated the payable interest for the actual installment, so this way we would consider it twice...
kulminsky
force-pushed
the
FINERACT-1981/pay_off_doesnt_consider_the_overdue_installments
branch
from
164215b
to
4e38547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pay-off calculation logic needs to be fixed to not only consider the payable details of the current period, but must add all the past due installments outstanding balances as well
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.