Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1981: Introduce Interest should not be calculated on past due principal amount #4191

Conversation

janez89
Copy link
Contributor

@janez89 janez89 commented Nov 26, 2024

This P.R. introduces a new flag on loan and loan product.

UPDATE: now this P.R. includes the business logic and integration tests also.

@adamsaghy
Copy link
Contributor

@janez89 Can you please attach some related test cases?

  • Set value on loan product, fetch value from loan product
  • Loan inherit it from loan product, fetch value from loan... etc

@janez89 janez89 marked this pull request as draft November 27, 2024 12:24
@janez89 janez89 force-pushed the feature/FINERACT-1981__intro_api_interest_should_not_calculated branch 2 times, most recently from 4012a13 to 20778c3 Compare November 27, 2024 16:42
@janez89 janez89 marked this pull request as ready for review November 27, 2024 16:42
@janez89 janez89 changed the title FINERACT-1981: Introduce Interest should not be calculated on past due principal amount on API FINERACT-1981: Introduce Interest should not be calculated on past due principal amount Nov 27, 2024
@janez89 janez89 force-pushed the feature/FINERACT-1981__intro_api_interest_should_not_calculated branch 2 times, most recently from 06c083a to 905cc8e Compare November 28, 2024 14:03
@janez89 janez89 force-pushed the feature/FINERACT-1981__intro_api_interest_should_not_calculated branch from 905cc8e to 906a386 Compare November 28, 2024 17:02
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 4cb849f into apache:develop Nov 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants