Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2081: Remove unnecessary toString method calls and fix typo #4317

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

a7med3del1973
Copy link
Contributor

@a7med3del1973 a7med3del1973 commented Feb 10, 2025

Description

  • Fixed Typo: Corrected "TRANSANCTIONS_LOGGED" to "TRANSACTIONS_LOGGED"
  • Fixed "reassigning" spelling
  • Removed redundant name().toString() calls to name().

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy
Copy link
Contributor

@a7med3del1973 Please make sure you always include the proper Fineract jira ticket in the PR title and in the commit message as well.
Example:
https://issues.apache.org/jira/browse/FINERACT-2081: Minor bug-fixes and enhancements of 1.11.0

So PR title and commit message could be the following:
FINERACT-2081: Remove unnecessary toString method calls and fix typo

@a7med3del1973 a7med3del1973 changed the title refactor: Optimize GL Account deletion validation FINERACT-2081: Remove unnecessary toString method calls and fix typo Feb 11, 2025
@adamsaghy adamsaghy merged commit 352d282 into apache:develop Feb 11, 2025
10 checks passed
@a7med3del1973 a7med3del1973 deleted the optimize-glaccount branch February 11, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants