FINERACT-2173: Introduce new loan migration module api #4319
+1,414
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulminsky
force-pushed
the
FINERACT-2173/introduce_new_loan_migration_module_api
branch
from
d4265c5 to
7c81309
Compare
adamsaghy
reviewed
Feb 11, 2025
| @@ -259,6 +259,8 @@ private NewCommandSourceHandler findCommandHandler(final CommandWrapper wrapper) | |||
| } else { | |||
| throw new UnsupportedCommandException(wrapper.commandName()); | |||
| } | |||
| } else if (wrapper.isLoanMigration()) { | |||
There was a problem hiding this comment.
No need... you can just use the proper annotations and will be picked up dynamically.
adamsaghy
reviewed
Feb 11, 2025
| // implementation dependencies are directly used (compiled against) in src/main (and src/test) | ||
| // | ||
| implementation(project(path: ':fineract-core')) | ||
| implementation(project(path: ':fineract-accounting')) |
There was a problem hiding this comment.
Do we need accounting and charge?
adamsaghy
reviewed
Feb 11, 2025
| @Schema(example = "MIGRATION_IN_PROGRESS", allowableValues = { "MIGRATION_IN_PROGRESS", "MIGRATION_SUCCESSFUL", "MIGRATION_FAILED" }) | ||
| private String action; | ||
|
|
||
| public String toJson() { |
There was a problem hiding this comment.
We use it in LoanMigrationApiResource
ex: new CommandWrapperBuilder().initiateLoanMigration(loanId).withJson(request.toJson()).build();
adamsaghy
reviewed
Feb 11, 2025
| private String status; | ||
|
|
||
| @Schema(example = "2024-01-01T12:00:00Z") | ||
| private LocalDateTime migrationStartDateTime; |
There was a problem hiding this comment.
Use OffsetDateTime please
There was a problem hiding this comment.
Also return dateformat to make easier to digest the consumer and locale...
adamsaghy
reviewed
Feb 11, 2025
| private Loan loan; | ||
|
|
||
| @Column(name = "migration_start_datetime", nullable = false) | ||
| private LocalDateTime migrationStartDateTime; |
There was a problem hiding this comment.
Use OffsetDateTime please
adamsaghy
reviewed
Feb 11, 2025
| private LocalDateTime migrationEndDateTime; | ||
|
|
||
| @Column(name = "status", nullable = false, length = 50) | ||
| private String status; |
adamsaghy
reviewed
Feb 11, 2025
| private CommandProcessingResult processMigrationCreation(Loan loan, String date, String dateFormat, String locale, String action) { | ||
| LocalDateTime migrationDate = parseDate(date, dateFormat, locale); | ||
|
|
||
| LoanMigration migration = LoanMigration.newInstance(loan, migrationDate, action); |
There was a problem hiding this comment.
Please add validations:
- We cannot mark completed or failed migration if it was never started for the loan: only loans where migration is IN PROGRESS can be marked as FAILED or COMPLETED
- We cannot mark loan as IN PROGRESS twice...
etc.
adamsaghy
reviewed
Feb 11, 2025
| LoanMigration migration = LoanMigration.newInstance(loan, migrationDate, action); | ||
| loanMigrationRepository.save(migration); | ||
|
|
||
| return new CommandProcessingResultBuilder().withEntityId(migration.getId()).build(); |
There was a problem hiding this comment.
Return the loan id as sub resource id please
kulminsky
force-pushed
the
FINERACT-2173/introduce_new_loan_migration_module_api
branch
from
7c81309 to
8e97351
Compare
kulminsky
force-pushed
the
FINERACT-2173/introduce_new_loan_migration_module_api
branch
from
8e97351 to
7a3237c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce new loan migration module api
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.