FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. #5131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman-Mittal
changed the title
Contributor
|
@Aman-Mittal Please make sure the commit message is matching with the PR title! |
Aman-Mittal
changed the title
… official Apache Kafka image.
Aman-Mittal
force-pushed
the
FINERACT-2402/kafka-docker-update
branch
from
6f6565c to
0d7b2f3
Compare
Contributor
Author
Closing this request and raising PR again |
Contributor
|
@Aman-Mittal No need for that. you have already changed the commit message. it got updated the PR automatically |
galovics
approved these changes
Oct 30, 2025
Contributor
|
LGTM |
Contributor
|
@IOhacker woah, that was a fast merge! 🚀 Has this been tested? Besides the indenting issue I mentioned, I'm seeing |
Contributor
|
Huh, apparently Docker [compose] allows both kinds of delimiters. I did a quick test and both worked fine. So, LGTM too, and now I'll go crawl back in my cave and grumble alone about unnecessary indentation. |
Contributor
Contributor
|
Ah right, CI hit that, thanks. I still don't like the colons though... I think we're getting lucky there with some undocumented behavior. They (Docker) don't test for it. I'll look into this. |
Contributor
|
I was wrong, whew. Looks like colons are supported: https://github.com/compose-spec/compose-go/blob/75fb1aba98ff8a944ebc5ea54f1054f1329e999c/dotenv/parser.go#L117 See also: |
3 tasks
Contributor
Author
|
@meonkeys Thanks for pointing it out, docker-compose indeed supports both : and = for parsing env files. However i should admit my mistake too. That i should use = instead of : in this project. As .env files format should be consistent across all project as older version docker may cause issue. |
Contributor
|
@Aman-Mittal cool. I'd say don't bother creating a new PR for this, but go ahead if you want to. If you do, ping me and I'll review it for you. |
6 tasks
adamsaghy
pushed a commit
to openMF/fineract
that referenced
this pull request
Nov 4, 2025
… official Apache Kafka image. (apache#5131) Co-authored-by: Aman Mittal <aman.mittal@cjdarcl.com>
hero78
added a commit
to racine-solutions/fineract
that referenced
this pull request
Jan 24, 2026
* FINERACT-2382: e2e test scenarios for flat cumulative multidisbursal loan * FINERACT-2385: Zero amount reage transaction should not be allowed * FINERACT-2385: e2e test scenarios for re-aging disallowed with zero amount * FINERACT-2354: added e2e tests for validation of re-aging for interest bearing products with interest calculation: default behavior * FINERACT-2354: First step - basic implementation of re-aging for Interest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change * Bump actions/upload-artifact from 4.6.2 to 5.0.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2390: e2e test scenarios for infinite loop with MIR trn issue * FINERACT-2390: Fix `infinite loop` issue * FINERACT-2389: Fix the handling of nullable field overrides * FINERACT-2389: Fix the handling of nullable field overrides - E2E tests * FINERACT-2398: Re-amortization Interest Handling configuration * FINERACT-2389: Upgrade OpenPDF to v3 * FINERACT-2354: Second step - charge-off edge case of re-aging for Interest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change * FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. (apache#5131) Co-authored-by: Aman Mittal <aman.mittal@cjdarcl.com> * FINERACT-2401: Add business events for interest pause actions * FINERACT-2401: e2e test scenarios interest pause biz events * FINERACT-2389: Update `Transaction Summary Report with Asset Owner` report * FINERACT-2402: Replace delimiter `:` with `=` in kafka-server.env * FINERACT-2394:Fixed Deposits is creating double Interest Postings * FINERACT-2403: Fix incorrect EMI calculation of last installment * FINERACT-2403: e2e test scenarios for last emi payment * FINERACT-2389: Fix for rounding mode not being initialized whenever a new tenant is added to the system without a restart * FINERACT-2406: Set `COMMIT` flush mode during transaction processing * FINERACT-2406: e2e test scenarios for flush mode while reprocessing * FINEREACT-2404: Improved extensibility and cleanup * FINERACT-2354: Reversal of re-aging transaction - remove restriction of reversal if there was payment after or on that day * FINERACT-2354: Reversal of re-aging transaction - E2E tests * FINERACT-2181: Add e2e test to verify repayment reversal after adding a fee charge with transaction reprocessing * FINERACT-2389: Fix for starting up in Liquibase only mode and pipeline to verify this to prevent breaking * FINERACT-2181: Update dependency io.github.bonigarcia:webdrivermanager to v6 * FINERACT-2181: Update dependency org.liquibase:liquibase-core to v5 * FINERACT-2181: Update dependency org.liquibase.ext:liquibase-postgresql to v5 * FINERACT-2354: Introduce reaging preview API * FINERACT-2354: e2e test scenarios for re-aging preview * FINERACT-2354: Third step - backdated re-age edge case for Interest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change * FINERACT-2354: Addding e2e tests covering - backdated re-age edge case for interest bearing loans * FINERACT-2354: Work with DTOs instead of entities inside ProgressiveEMICalculator * FINERACT-2354: In case full transaction reprocessing, we need to recalculate the schedule as well * FINERACT-2354: Re-aging: DEFAULT BEHAVIOUR - Reverse Replay handling, additional test case * FINERACT-2354: e2e test scenarios for re-aging reverse-replay for default behaviour * FINERACT-2354: Fourth step - Chargeback before re-age edge case for Interest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change * FINERACT-2354: Fourth step - Chargeback before re-age edge case for Interest bearing loans - updated e2e scenario tags * FINERACT-2326: Loan contract termination same disbursement date * FINERACT-2326: Loan contract termination same disbursement date - E2E * FINERACT-2326: Fix duplicate reverse replay of ‘Accrual Activity’ during reprocessing * FINERACT-1724: [doc] Downpayment user documentation * FINERACT-2181: Update dependency org.yaml:snakeyaml to v2 * FINERACT-2181: Update ghcr.io/navikt/mock-oauth2-server Docker tag to v3 * FINERACT-2181: Update actions/stale action to v10 * FINERACT-2407: add permission READ_FAMILYMEMBERS * FINERACT-2407: add permission READ_FAMILYMEMBERS id removed field=id * FINERACT-2407: add precheck * FINERACT-2389: Negative amount is shown on repayment schedule * FINERACT-2389: Pay-Off amount incorrectly calculated when downpayment * FINERACT-2405: totalUnpaidPayableNotDueInterest resets to 0 on Charge-Off * FINERACT-2354: Re-aging: -Interest Handling Option: Equal amortization * FINERACT-2354: e2e test scenarios for re-aging with payable and full interest handling options * FINERACT-2326: Update Transaction Summary report with txn classification details * FINERACT-2354: Re-aging: EQUAL AMORTIZATION BEHAVIOUR - Reversal of Re-aging transaction - E2E tests * FINERACT-2181: Update dependency org.jruby:jruby-complete to v10 * Bump actions/checkout from 5.0.0 to 6.0.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2380: move retrofit client based test to feign * FINERACT-2380: move retrofit client based test to feign * FINERACT-2354: Re-aging: EQUAL AMORTIZATION BEHAVIOUR - Reversal of Re-aging transaction - extra E2E tests * FINERACT-2181: Update groovy monorepo to v5 * FINERACT-2411: Allow empty columns to be deleted from datatables * FINERACT-2354: e2e test scenarios for reverse-replay re-aging with equal amortization * FINERACT-2354: Re-age - Excess payment handling - Default Behavior, interestRecalculation = true * FINERACT-2354: Added e2e tests for partially paid installment - adjust to last edge case of re-aging * FINERACT-2354: Re-age - Excess payment handling - Default Behavior, interestRecalculation = true, without dueDate change - missing testRailIds added * FINERACT-2354: add reaging interest template data * FINERACT-2346: Refractor, Minor Sonar fixes and remove some deprecated code * FINERACT-2389: Pay-Off amount calculated after Contract Termination * FINERACT-2389: e2e test scenarios with pay-off after contract termination * FINERACT-2181: Update actions/checkout digest to 93cb6ef * FINERACT-2181: Update actions/setup-node digest to 49933ea * FINERACT-2326: Downgrade liquibase due to licensing concerns (apache#5190) * FINERACT-2316: Localize interest rate chart slab validation - Add localized validation messages for overlap and gap errors in interest rate chart slabs - Use DataValidatorBuilder with resource/parameter context for clean error codes - Add unit tests for validation error codes and arguments - Add German translations for validation messages * FINERACT-2354: e2e test scenarios with multidisburse and CI after re-aging * FINERACT-1981: Fix reschedule installment for progressive loans * FINERACT-2326: Not implemented exception handling * Bump actions/checkout from 5.0.1 to 6.0.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/stale from 10.1.0 to 10.1.1 Bumps [actions/stale](https://github.com/actions/stale) from 10.1.0 to 10.1.1. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@5f858e3...9971854) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.1.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/setup-node from 4.4.0 to 6.1.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@49933ea...395ad32) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2326: Add extra valid checksum since Liquibase changed on how checksums calculated * FINERACT-2326: Force single-threaded execution of tenant database upgrades * FINERACT-2354: Validation of Re-age amount during submission * FINERACT-2354: [doc] Re-aging functional description * Bump actions/setup-java from 5.0.0 to 5.1.0 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@dded088...f2beeb2) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: 5.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2326: Add configuration options for CORS handling * FINERACT-2398: Re-amortization:- Interest handling-Default behavior * FINERACT-2398: added e2e test cases for validation of re-amortization:- Interest handling-Default behavior * FINERACT-2354: added e2e tests verifying re-aging which changes the due dates and frequencies - Default Behavior, interestRecalculation=true * FINERACT-2326: Refractor redundant and some deprecated code as per new Java 21 style * FINERACT-2354: Schedule handling after re-age - points 4-5-6 * FINERACT-2398: Re-amortization:- Preview Schedule API during re-amortization * FINERACT-2398: Re-amortization:- Preview Schedule API during re-amortization - E2E tests * FINERACT-2312: full term configuration added * FINERACT-2326: Fix configuration options for CORS (apache#5210) * FINERACT-2354: Validation of Re-age amount during submission * FINERACT-2354: [BE] chargeback handling with backdated re-age for last adjustment strategy with equal amortization re-aging behaviour * FINERACT-2354: e2e test scenarios for re-age with chargeback for last instalment strategy * FINERACT-2326: Fix external id generation during reinvest * FINERACT-2354: e2e test scenario for disbursement amount less than one * FINERACT-2389: EMI rounding handling * FINERACT-2354: e2e test scenario for re-age with equal amortization with interest pause * FINERACT-2416: improve PR template I started editing this just to fix the link to the "Pull Requests" doc (it moved from README.md to CONTRIBUTING.md), but then I saw a few other places in need of service. * use Markdown links for readability * add link to pull request size limit wiki page re: code dumps * remove link to PR 1284, it doesn't add anything here and takes the reader out of context * add link to mailing list * add link to testing docs * link to new vulnerabilities list * Bump actions/cache from 4.3.0 to 5.0.0 Bumps [actions/cache](https://github.com/actions/cache) from 4.3.0 to 5.0.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0057852...a783357) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2354: [BE] re-aging preview page outcomes with incorrect calculation for diff scenarios with interest bearing loans * FINERACT-2354: e2e tests for re-age preview with equal amortization * FINERACT-2790: Re-amortization- Interest handling-Equal Overdue Interest Split - E2E tests * FINERACT-2398: Add handling for equal overdue interest split re-amortization * FINERACT-2415: Refactor InlineLoanCOBExecutorServiceImpl to reduce duplication * FINERACT-2181: Update actions/checkout digest to 93cb6ef * FINERACT-2312: fix missing allowFullTermForTranche parameter for the Calculate the Loan Schedule * FINERACT-2354: e2e tests with equal amortization moved into separate feature file * Bump actions/cache from 5.0.0 to 5.0.1 Bumps [actions/cache](https://github.com/actions/cache) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@a783357...9255dc7) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/upload-artifact from 5.0.0 to 6.0.0 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@330a01c...b7c566a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/checkout from 5.0.1 to 6.0.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2181: Update actions/setup-node digest to 49933ea * FINERACT-2181: Update actions/cache digest to 0057852 * Bump actions/setup-node from 4.4.0 to 6.1.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@49933ea...395ad32) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2326: Refactor trial balance processing to reduce cognitive complexity * FINERACT-2354: Chargeback handling with backdated re-age - with default re-aging behaviour * FINERACT2354: e2e tests for re-aging with default behaviour with backdated re-aging * added e2e tests for backdated re-aging with default behaviour * FINERACT-2354: Re-aging: Repayment schedule handling in case of overlapping Interest pause * FINERACT2354: added e2e tests for re-aging with equal amortization with backdated interest pause * Bump actions/cache from 4.3.0 to 5.0.1 Bumps [actions/cache](https://github.com/actions/cache) from 4.3.0 to 5.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0057852...9255dc7) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2326: Refractor redundant and some deprecated code as per new Java 21 style (Phase 2) * FINERACT-2354: Loan reschedule with extra terms after re-aging * FINERACT-2354: e2e tests for re-age with equal amortization with reschedule * FINERACT-2413: e2e tests for re-amortization reverse-replay handling * FINERACT-2413: Re-amortization reverse replay handling * FINERACT-2421: Fix kubernetes minikube example configuration * FINERACT-2421: Upgrade dependencies (apache#5244) * FINERACT-2421: Upgrade dependencies * improve start release notes wording in step 3 * doc: remove errant config similar to 45404ba All asciidoctor config must be in `fineract-doc/src/docs/en/config.adoc`. In this case `:sectnums:` re-starts ToC section numbering partway through the ToC. * fix both NOTICE files for ATR ATR (the ASF Trusted Releases tool) expects these to follow a very specific template. In this case I had to s/by/at/ and add a newline. See: https://github.com/apache/tooling-trusted-releases/blob/52e202f2deae74d38bc60849736339b2ab919de8/atr/tasks/checks/license.py#L299 * add license to scripts/*.sh conform rather than bypass RAT license check * add RAT excludes for ATR * add license to .mailmap ATR was complaining * ignore .swp files when building src release just in case. I accidentally did this while working on the 1.14.0 release. * FINERACT-2354:added e2e test for validation of re-aging with various interest handling is forbidden on written-off loan * FINERACT-2354: e2e tests for re-age with equal amortization forbidden after write-off * FINERACT-792: Improve developer environment setup and IntelliJ IDEA guidance * docs: update Java version requirement to Java 21 * docs: updated Java version requirement to Java 21 * exclude jquery-1.7.min.js from source release This is to workaround an issue, UI misunderstanding, or PEBKAC with the ATR (ASF Trusted Releases) tool wherein I am unable to exclude the license header check for this file. jQuery (and its dependencies) can be used entirely under the MIT, see <https://jquery.com/license/>. Once apache/tooling-trusted-releases#312 ... is resolved we should be able to revert this workaround. While this workaround is in place, consumers of apiLive.htm must: 1. put a copy of jquery-1.7.min.js next to apiLive.htm 2. change apiLive.htm to refer to jquery-1.7.min.js on a CDN If someone needing apiLive.htm prefers the first option, they can grab a copy at https://code.jquery.com/jquery-1.7.min.js . If they prefer the second option, they can pick a minified or unminified link listed at https://blog.jquery.com/2011/11/03/jquery-1-7-released/ and modify line 6 of apiLive.htm to refer to that instead, for example: - <script type="text/javascript" src="jquery-1.7.min.js"></script> + <script type="text/javascript" src="https://code.jquery.com/jquery-1.7.min.js"></script> There are other ways to deal with the license header check as well. For example: We could use 2nd option above (always), or finally/actually port away from apiLive.htm (it is in legacy-docs, after all). * improve svn release staging/release instructions All good. I tested these just now. ATR so far does artifact checks & voting/email management. Working with artifacts on the svn server is still our responsibility, for now. * docs: adapt artifact checks to new ATR tool We're already reaping rewards for using ATR (checks+voting+email support), and I want us to do both the old way AND the new way for now. I'll consider the old release process in "soft deprecation" as the ATR matures. * port steps 10 & 11 to the ATR * update manual release instructions Not gonna lie, I'm getting tired of maintaining this second source of truth. Hopefully my laziness, impatience, and hubris will tip the scales far enough to delete it. * FINERACT-2424: post 1.14.0 release docs cleanup * Go analog for step 15, automation was broken. * Fix two admonitions: I meant to use `NOTE`. `INFO` is not a valid admonition in asciidoc, so it just shows up as text. * FINERACT-2181: Update actions/cache digest to 0057852 * FINERACT-2421: Fix lombok annotations * FINERACT-2413: Improve re-amortization undo validation * FINERACT-2354: e2e tests for re-amortization undo * FINERACT-2181: Improve validation for reschedule fromDate parameter * FINERACT-2181: Improve validation for reschedule fromDate parameter - E2E tests * FINERACT-2181: Update actions/checkout digest to 93cb6ef * FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 3) * FINERACT-2413: Re-amortization on charged-off, contract terminated & written-off loan * FINERACT-2413: e2e tests for re-amortization forbidden for charged-ff or written-off loan * Bump actions/checkout from 5.0.1 to 6.0.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 4.3.0 to 5.0.1 Bumps [actions/cache](https://github.com/actions/cache) from 4.3.0 to 5.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0057852...9255dc7) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2421: Fix potential NullPointerException in CalendarCommandFromApiJsonDeserializer The extractBooleanNamed method can return null when the JSON value is null or missing. Using primitive boolean causes automatic unboxing which throws NullPointerException. Changes: - CalendarCommandFromApiJsonDeserializer: Use Boolean wrapper instead of primitive boolean for 'repeating' field extraction - CalendarCommandFromApiJsonDeserializer: Use Boolean.TRUE.equals() for null-safe boolean comparison - CalendarCommand: Update field type and constructor parameter from boolean to Boolean to support null values This addresses the FIXME comments on lines 156 and 298 in the original file. * FINERACT-2421: Simplify InputStream to String conversion using Java 11+ API * FINERACT-2181: Update actions/cache digest to 0057852 * FINERACT-2181: Update actions/checkout digest to 93cb6ef * Bump actions/cache from 4.3.0 to 5.0.1 Bumps [actions/cache](https://github.com/actions/cache) from 4.3.0 to 5.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0057852...9255dc7) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/checkout from 5.0.1 to 6.0.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2425: Tax component and Tax Group refactoring * FINERACT-2206: Fix typo in allowPartialPeriodInterestCalculation Fixed misspelled 'allowPartialPeriodInterestCalcualtion' to 'allowPartialPeriodInterestCalculation' in REST API and code. 35 files updated as specified in JIRA. * FINERACT-2206: Fix date inconsistency in SavingsInterestPostingTest Fixed startDate from dynamic current year to hardcoded 2025 in testPostInterestNotZero() to maintain consistent 2025 timeline. Resolves HTTP 400 error caused by date mismatches. * FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants (apache#5284) * FINERACT-2421: Improved Spring Batch context handling * FINERACT-2431: Fix typo in populateSharedAccountsWorkbook (apache#5293) * FINERACT-2174: added e2e tests covering extended migration scenario with fees/penalties * FINERACT-2173: added e2e tests covering extended migration scenario with special transaction types and conditions * FINERACT-2433: Fix interest and accrual calculation in case of last installment payment * FINERACT-2433/fix-interest-accrual-calculation - E2E test * FINERACT-2434: Add input validation to split-tests.sh script (apache#5296) Co-authored-by: FarhanAlstonair <Farhan@github123> * [#FINERACT-2422] standardize use of aging vs. ageing (apache#5289) * FINERACT-2422: standardize use of aging vs. ageing (apache#5302) * FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 4) * FINERACT-2421: fix(security): migrate request matchers to PathPatternRequestMatcher (no behavior change) * FINERACT-2181: Update actions/cache digest to 0057852 * FINERACT-2429: Fix typo getCreditAcount to getCreditAccount in TaxComponent and SavingsAccountTransaction * FINERACT-2790: e2e tests for re-amortization with equal interest split with diff trns afterwards * FINERACT-2421: Set back the XmX to 12g * Revert "[#FINERACT-2422] standardize use of aging vs. ageing (apache#5289)" This reverts commit 61034e6. * Revert "FINERACT-2422: standardize use of aging vs. ageing (apache#5302)" This reverts commit 174da7d. * FINERACT-2421: Fix GRETERTHAN typo in ConditionType enum * FINERACT-2432 * FINERACT-2421: [doc] Pause delinquency user documentation * FINERACT-2421: Add `Verify Liquibase Backward Compatibility` check * Revert "exclude jquery-1.7.min.js from source release" This reverts commit 7923d9e. See that commit's log message, and apache/tooling-trusted-releases#427 TL;DR → ATR now ignores files ending in .min.js so we no longer need the explicit exclude for jquery-1.7.min.js * Bump actions/setup-java from 4 to 5 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 4.3.0 to 5.0.1 Bumps [actions/cache](https://github.com/actions/cache) from 4.3.0 to 5.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0057852...9255dc7) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2389: Reprocess Interest Refund txn amount if no txn was changed * FINERACT-2421: added e2e test for verifying reprocess Interest Refund txn amount if no txn was changed * FINERACT-2412: Full term tranche - Schedule handling and Calculations * FINERACT-2354: Re-aging:- Accrual and Accrual Activity handling - Default Handling * FINERACT-2354: e2e tests for re-aging with accruals for default behaviour * FINERACT-2412: Full term tranche - monetary transaction allocation * FINERACT-2421: Add unit tests for ExternalIdFactory (apache#5276) * FINERACT-2421: Add unit tests for ExternalIdFactory * FINERACT-2421: Fix ambiguous method reference in ExternalIdFactoryTest Cast null to String to resolve ambiguous method call between produce(String) and produce(List<String>) overloads. * FINERACT-2421: Add unit tests for SQLBuilder * FINERACT-1266: Fix NullPointerException in SavingsHelper.determineInterestPostingPeriods * Fix(FINERACT-2320): Return false instead of 403 when Loan COB job is disabled * FINERACT-2421: [doc] Asset Externalization documentation * FINERACT-2430: Fix typo: rename 'acount' to 'account' * FINERACT-2354: handle reamortization error code 500 issue on same disbursement day * FINERACT-2421: Make "Business date configuration" reliable * FINERACT-2412: Full term tranche - downpayment handling * FINERACT-2413: Add re-amortization documentation * FINERACT-2421: Allow reage preview API via Batch API * Bump actions/setup-node from 6.1.0 to 6.2.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@395ad32...6044e13) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2412: Full term tranche - undo last disbursement support * FINERACT-2423: Fix invalid Liquibase changelog filename with space Apply spotless formatting FINERACT-2423: Add Liquibase changeset to fix invalid 0072 filename FINERACT-2423: Remove unnecessary whitespace in changelog-tenant.xml FINERACT-2423: Add Apache license header to Liquibase changelog FINERACT-2423: Add Apache license header to Liquibase changeset Fix for FINERACT-2423: [Your fix description] - Applied code formatting (spotlessApply) - Passed SpotBugs checks - Passed Checkstyle test checks * Fix Liquibase changelog formatting and failing elements * FINERACT-2423: Remove redundant 0071 fix and keep safe 0072 migration * FINERACT-2423: Add preconditions to all changesets * FINERACT-2421: Move E2E init data into `runner` * FINERACT-2421: Rework code value handling in E2E * FINERACT-2086: Fix ClassCastException in AccountAssociations and add unit tests - Simplified conversion using Number.intValue() to handle Short and Integer types. - Removed redundant null checks as per feedback. - Added unit tests for type-safety verification. * FINERACT-2055 Internal Server Error Encountered When Accessing Individual Collection Sheet Option * Bump actions/cache from 5.0.1 to 5.0.2 Bumps [actions/cache](https://github.com/actions/cache) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@9255dc7...8b402f5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * FINERACT-2421: Undo Last Disbursement failed after reaging * FINERACT-2389: Loan reschedule with adjustedDueDate after re-age * FINERACT-2418: create the loan origination module * FINERACT-2428: Fix 'acount' typo to 'account' in legacy docs * FINERACT-2164: Add Gradle SBOM (Software Bill of Materials) generator - Add CycloneDX plugin for SBOM generation (version 3.1.0) - Configure as optional task (not part of default build) - Generate SBOM in CycloneDX format with license information - Usage: ./gradlew :fineract-provider:cyclonedxDirectBom Output: build/reports/cyclonedx-direct/bom.{json,xml} * FINERACT-2354: Re-aging - Accrual and Accrual Activity handling - Equal Amortization * FINERACT-2354: e2e tests for re-aging with accruals for equal amortization * FINERACT-2413: Schedule handling after re-amortization default behavior * FINERACT-2413: added e2e tests for validation of schedule handling after re-amortization default behavior * FINERACT-2437: Decrease the number of compilation warnings * FINERACT-2389: incorrect repayment schedule amount calculations for 2nd disb, CI and other actions after re-amortization * FINERACT-2389: added e2e test validating incorrect repayment schedule amount calculations for 2nd disb, CI and other actions after re-amortization * fix merge conflicts * fix merge conflicts * fix merge conflicts * fix merge conflicts * fix merge conflicts * fix merge conflicts --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: MarianaDmytrivBinariks <mdmytriv@binariks.com> Co-authored-by: Oleksii Novikov <alexey.novikov@onix-systems.com> Co-authored-by: Rustam Zeinalov <truezeynalov@gmail.com> Co-authored-by: mariiaKraievska <riaskay3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Saghy <adamsaghy@gmail.com> Co-authored-by: Peter Kovacs <peter.kovacs@dpc.hu> Co-authored-by: Jose Alberto Hernandez <alberto@black-box.local> Co-authored-by: Andreas Røsdal <andreas.rosdal@gmail.com> Co-authored-by: Aman-Mittal <32237955+Aman-Mittal@users.noreply.github.com> Co-authored-by: Aman Mittal <aman.mittal@cjdarcl.com> Co-authored-by: alburquerquerangelarturo <alburquerquerangelarturo@gmail.com> Co-authored-by: Arnold Galovics <galovicsarnold@gmail.com> Co-authored-by: cucusenok <BP-116: updated readme.md> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Akshat Soni <akshatsoni@Akshats-MacBook-Air.local> Co-authored-by: Soma Sörös <soma.soros@dpc.hu> Co-authored-by: Attila Budai <budai.attila.istvan@gmail.com> Co-authored-by: Ralph Hopman <ralph@hopman.nl> Co-authored-by: Aman-Mittal <aman.mittal3052000@gmail.com> Co-authored-by: Siddharthan P S <sidshas03@gmail.com> Co-authored-by: mariiaKraievska <105638281+mariiaKraievska@users.noreply.github.com> Co-authored-by: Adam Monsen <haircut@gmail.com> Co-authored-by: Satvik Mishra <satvikmishra2192@gmail.com> Co-authored-by: Victor Romero <victor.romero@fintecheando.mx> Co-authored-by: Ahmed Adel <a7med3del1973@gmail.com> Co-authored-by: Dömötör D. Lugosi <lugalaci@gmail.com> Co-authored-by: Monica-CodingWorld <monicandastudy1412@gmail.com> Co-authored-by: airajena <airajena.hack@gmail.com> Co-authored-by: Kengne-yvana <132190143+Kengne-yvana@users.noreply.github.com> Co-authored-by: ap200506-sudo <ap200506@gmail.com> Co-authored-by: Farhantigadi <109067327+Farhantigadi@users.noreply.github.com> Co-authored-by: FarhanAlstonair <Farhan@github123> Co-authored-by: Víctor Romero <46640258+IOhacker@users.noreply.github.com> Co-authored-by: Wilfred Kigenyi <wkigenyi@gmail.com> Co-authored-by: Aira Jena <113255984+airajena@users.noreply.github.com> Co-authored-by: Shiv Deshpande <shivd131@gmail.com> Co-authored-by: yvana-kengne <yvanakengne@gmail.com> Co-authored-by: airajena <airajena0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-2402
See also: DEPRECATION - Publicly available Bitnami Kafka docker images mailing list thread
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.